[ https://issues.apache.org/jira/browse/YARN-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323743#comment-16323743 ]
Sunil G commented on YARN-7738: ------------------------------- Thanks [~leftnoteasy]. Fix seems fine to me Few comments: # {{Resource#setResourceValue}} will internally take care of checking whether resource name is memory or vcores and accordingly call setMemorySize or setVirtualCores. Hence we could avoid {{setMaximumAllocationByConfiguredResourceInformation}} in ResourceUtils. # {{if (!Resources.fitsIn(oldMax, newMax))}} could we make its like {{if (Resources.fitsIn(newMax, oldMax))}}. fitsIn checks smaller as first arg. TO check test cases, i ll try attach a patch with this changes. > CapacityScheduler: Support refresh maximum allocation for multiple resource > types > --------------------------------------------------------------------------------- > > Key: YARN-7738 > URL: https://issues.apache.org/jira/browse/YARN-7738 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Sumana Sathish > Assignee: Tan, Wangda > Priority: Blocker > Fix For: 3.1.0, 3.0.1 > > Attachments: YARN-7738.001.patch, YARN-7738.002.patch > > > Currently CapacityScheduler fails to refresh maximum allocation for multiple > resource types. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org