[
https://issues.apache.org/jira/browse/YARN-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328312#comment-16328312
]
Vrushali C commented on YARN-6736:
----------------------------------
Thanks [~agresch] for the patch and [~rohithsharma] for the reviews and commit!
I had a few basic questions.
- in ApplicationMaster # init, the patch removes the setting of
timelineServiceV1Enabled
at line 638 but uses it at line 709. Since it is not set, this will not invoke
publishApplicationAttemptEvent I think?
Similarly for timelineServiceV2Enabled at lines 701.
- The Float f = Float.parseFloat(s); is likely to throw a number format
exception in case of some misconfiguration in the config values. Perhaps a good
idea to catch this and ignore and proceed.
- Not very important but I didn’t get why the conf settings for timeline server
address & port had to be moved out of synchronized in MiniYARNCluster were in
this patch?
> Consider writing to both ats v1 & v2 from RM for smoother upgrades
> ------------------------------------------------------------------
>
> Key: YARN-6736
> URL: https://issues.apache.org/jira/browse/YARN-6736
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Vrushali C
> Assignee: Aaron Gresch
> Priority: Major
> Fix For: 3.1.0, 2.10.0, 3.0.1, yarn-7055
>
> Attachments: YARN-6736-YARN-5355.001.patch,
> YARN-6736-YARN-5355.002.patch, YARN-6736-YARN-5355.003.patch,
> YARN-6736-YARN-5355.004.patch, YARN-6736-YARN-5355.005.patch,
> YARN-6736.001.patch, YARN-6736.002.patch
>
>
> When the cluster is being upgraded from atsv1 to v2, it may be good to have a
> brief time period during which RM writes to both atsv1 and v2. This will help
> frameworks like Tez migrate more smoothly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
