[ https://issues.apache.org/jira/browse/YARN-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332963#comment-16332963 ]
Haibo Chen commented on YARN-5473: ---------------------------------- Thanks [~snemeth] for the review! For 1) and 2), given the patch is already very large and there are only 1 or 2 constructors, I think we can leave the refactoring to another jira. For 4), instead of adding three more methods, I used anonymous HashMap class to make it more readable. 3), 5) and 6) are all addressed accordingly. Thanks again for the review. > Expose per-application over-allocation info in the Resource Manager > ------------------------------------------------------------------- > > Key: YARN-5473 > URL: https://issues.apache.org/jira/browse/YARN-5473 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Íñigo Goiri > Assignee: Haibo Chen > Priority: Major > Attachments: YARN-5473-YARN-1011.00.patch, > YARN-5473-YARN-1011.01.patch, YARN-5473-YARN-1011.02.patch, > YARN-5473-YARN-1011.prelim.patch > > > When enabling over-allocation of nodes, the resources in the cluster change. > We need to surface this information for users to understand these changes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org