[ 
https://issues.apache.org/jira/browse/YARN-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338144#comment-16338144
 ] 

Carlo Curino commented on YARN-6648:
------------------------------------

[~botong] thanks for updating the patch, +1 from me, with the following minor 
issues:
 # Fix the findbugs exclusion (I see you are already trying to do so, but seems 
that your offering have not please the Yetus gods yet :)).
 # (minor) {{SubclusterCleaner}} lineĀ  98 theĀ {{LOG.info}} seems a bit 
redundant, maybe LOG.debug? I see it being useful while debugging, but during 
normal operations is somewhat unnecessary

> [GPG] Add SubClusterCleaner in Global Policy Generator
> ------------------------------------------------------
>
>                 Key: YARN-6648
>                 URL: https://issues.apache.org/jira/browse/YARN-6648
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>            Priority: Minor
>              Labels: federation, gpg
>         Attachments: YARN-6648-YARN-2915.v1.patch, 
> YARN-6648-YARN-7402.v2.patch, YARN-6648-YARN-7402.v3.patch, 
> YARN-6648-YARN-7402.v4.patch, YARN-6648-YARN-7402.v5.patch, 
> YARN-6648-YARN-7402.v6.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to