[
https://issues.apache.org/jira/browse/YARN-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752950#comment-13752950
]
Chuan Liu commented on YARN-1077:
---------------------------------
In the new patch, I removed the following code because writer is writing to
shellFile but later the file outputsteam opens the file without append mode. So
the code is simply dead code.
{code:java}
shellFile = Shell.appendScriptExtension(tmpDir, "hello");
- String timeoutCommand = Shell.WINDOWS ? "@echo \"hello\"" :
- "echo \"hello\"";
- PrintWriter writer = new PrintWriter(new FileOutputStream(shellFile));
- FileUtil.setExecutable(shellFile, true);
- writer.println(timeoutCommand);
- writer.close();
Map<Path, List<String>> resources =
new HashMap<Path, List<String>>();
FileOutputStream fos = new FileOutputStream(shellFile);
{code}
> TestContainerLaunch fails on Windows
> ------------------------------------
>
> Key: YARN-1077
> URL: https://issues.apache.org/jira/browse/YARN-1077
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.3.0
> Reporter: Chuan Liu
> Assignee: Chuan Liu
> Priority: Minor
> Attachments: YARN-1077.2.patch, YARN-1077.3.patch, YARN-1077.patch
>
>
> Several cases in this unit tests fail on Windows. (Append error log at the
> end.)
> testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and
> bash script error handling. If some command fails in the cmd script, cmd will
> continue execute the the rest of the script command. Error handling needs to
> be explicitly carried out in the script file. The error code of the last
> command will be returned as the error code of the whole script. In this test,
> some error happened in the middle of the cmd script, the test expect an
> exception and non-zero error code. In the cmd script, the intermediate errors
> are ignored. The last command "call" succeeded and there is no exception.
> testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands
> used by the test.
> testContainerEnvVariables and testDelayedKill fail due to a regression from
> YARN-906.
> {noformat}
> -------------------------------------------------------------------------------
> Test set:
> org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch
> -------------------------------------------------------------------------------
> Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec
> <<< FAILURE!
> testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch)
> Time elapsed: 583 sec <<< FAILURE!
> junit.framework.AssertionFailedError: Should catch exception
> at junit.framework.Assert.fail(Assert.java:50)
> at
> org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269)
> ...
> testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch)
> Time elapsed: 561 sec <<< FAILURE!
> junit.framework.AssertionFailedError: Should catch exception
> at junit.framework.Assert.fail(Assert.java:50)
> at
> org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314)
> ...
> testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch)
> Time elapsed: 4136 sec <<< FAILURE!
> junit.framework.AssertionFailedError: expected:<137> but was:<143>
> at junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.failNotEquals(Assert.java:287)
> at junit.framework.Assert.assertEquals(Assert.java:67)
> at junit.framework.Assert.assertEquals(Assert.java:199)
> at junit.framework.Assert.assertEquals(Assert.java:205)
> at
> org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerEnvVariables(TestContainerLaunch.java:500)
> ...
> testDelayedKill(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch)
> Time elapsed: 2744 sec <<< FAILURE!
> junit.framework.AssertionFailedError: expected:<137> but was:<143>
> at junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.failNotEquals(Assert.java:287)
> at junit.framework.Assert.assertEquals(Assert.java:67)
> at junit.framework.Assert.assertEquals(Assert.java:199)
> at junit.framework.Assert.assertEquals(Assert.java:205)
> at
> org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testDelayedKill(TestContainerLaunch.java:601)
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
