[ 
https://issues.apache.org/jira/browse/YARN-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuan Liu updated YARN-1120:
----------------------------

    Attachment: YARN-1120.patch

Attach a patch. I verified that both TestUnmanagedAMLauncher and 
TestContainerLaunch are passing with this patch on Windows.
                
> Make ApplicationConstants.Environment.USER definition OS neutral
> ----------------------------------------------------------------
>
>                 Key: YARN-1120
>                 URL: https://issues.apache.org/jira/browse/YARN-1120
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>         Attachments: YARN-1120.patch
>
>
> In YARN-557, we added some code to make {{ 
> ApplicationConstants.Environment.USER}} has OS-specific definition in order 
> to fix the unit test TestUnmanagedAMLauncher. In YARN-571, the relevant test 
> code was corrected. In YARN-602, we actually will explicitly set the 
> environment variables for the child containers. With these changes, I think 
> we can revert the YARN-557 change to make {{ 
> ApplicationConstants.Environment.USER}} OS neutral. The main benefit is that 
> we can use the same method over the Enum constants. This should also fix the 
> TestContainerLaunch#testContainerEnvVariables failure on Windows. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to