[ https://issues.apache.org/jira/browse/YARN-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353193#comment-16353193 ]
Suma Shivaprasad commented on YARN-7789: ---------------------------------------- Patch LGTM. A few minor comments. 1.Can we reword the failure message from + throw new YarnRuntimeException("Invalid resource types specified when" + + " enabling GPU, resource manager should fail if 3rd resource" + + " type is configured but RM uses DefaultResourceCalculator"); to convey that Default + throw new YarnRuntimeException("RM uses DefaultResourceCalculator which used only memory as resource-type but invalid resource-types specified " + <list of resource types>) . Use DomainantResourceCalculator instead to make effective use of these resource-types " 2. Please add a UT for the same. > Should fail RM if 3rd resource type is configured but RM uses > DefaultResourceCalculator > --------------------------------------------------------------------------------------- > > Key: YARN-7789 > URL: https://issues.apache.org/jira/browse/YARN-7789 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Sumana Sathish > Assignee: Zian Chen > Priority: Critical > Attachments: YARN-7789.001.patch > > > We may need to revisit this behavior: Currently, RM doesn't fail if 3rd > resource type is configured, allocated containers will be automatically > assigned minimum allocation for all resource types except memory, this makes > really hard for troubleshooting. I prefer to fail RM if 3rd or more resource > type is configured inside resource-types.xml. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org