[
https://issues.apache.org/jira/browse/YARN-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356652#comment-16356652
]
Bibin A Chundatt edited comment on YARN-7875 at 2/8/18 8:51 AM:
----------------------------------------------------------------
[~cheersyang]
Thank you for looking at patch,
# Refactoring was done mainly to have {{CommonFileSystem}} implementation for
Store
# Read and write common code is pushed to {{FileSystemDescriptorStore}}
# Intention was to have 2 different store for Attributes and NodeLabels
{quote}
* updateNodeToLabelsMappings vs replaceNodeAttributes
* storeNewClusterNodeLabels vs addNodeAttributes
* removeClusterNodeLabels vs removeNodeAttributes
{quote}
addNodeAttributes,removeNodeAttributes,replaceNodeAttributes is for only Node
to Attributes mapping. storeNewClusterNodeLabels,removeClusterNodeLabels is
mainly for cluster level label addition
{quote}
If we really want to refactor the class to be more generic so labels and
attributes store can share most of code
{quote}
Could you explain further.
Along with above changes few modification related to mirror file opening is
also done as part of refactoring.
Will wait for [~sunil.gov...@gmail.com] and [~naganarasimha...@apache.org] too
before i upload first patch
was (Author: bibinchundatt):
[~cheersyang]
Thank you for looking at patch,
# Refactoring was done mainly to have CommonFileSystem implementation for
Store
# Currently i was planning to have 2 different store for Attributes and Labels
{quote}
* updateNodeToLabelsMappings vs replaceNodeAttributes
* storeNewClusterNodeLabels vs addNodeAttributes
* removeClusterNodeLabels vs removeNodeAttributes
{quote}
# addNodeAttributes,removeNodeAttributes,replaceNodeAttributes is for only
Node to Attributes mapping. storeNewClusterNodeLabels,removeClusterNodeLabels
is mainly for cluster level label addition
{quote}
{quote}
> AttributeStore for store and recover attributes
> -----------------------------------------------
>
> Key: YARN-7875
> URL: https://issues.apache.org/jira/browse/YARN-7875
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-7875-WIP.patch, YARN-7875-WIP.patch
>
>
> Similar to NodeLabelStore need to support NodeAttributeStore for persisting
> attributes mapping to Nodes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
