[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361907#comment-16361907
]
Sunil G commented on YARN-7920:
-------------------------------
Thanks [~leftnoteasy] for the patch. Refactoring looks fine to me.
Few comments in general
# {{YarnConfiguration.java}} has few new properties added, could you please
help to update javadoc of those a bit more with details.
# For above configs, i think we can skip
DEFAULT_RM_PLACEMENT_CONSTRAINTS_HANDLER and have only
NONE_RM_PLACEMENT_CONSTRAINTS_HANDLER
# Please update {{PlacementConstraints.md.vm}} where we are mentioning about
{{yarn.resourcemanager.placement-constraints.enabled}}
> Cleanup configuration of PlacementConstraints
> ---------------------------------------------
>
> Key: YARN-7920
> URL: https://issues.apache.org/jira/browse/YARN-7920
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Priority: Blocker
> Attachments: YARN-7920.001.patch
>
>
> Currently it is very confusing to have the two configs in two different files
> (yarn-site.xml and capacity-scheduler.xml).
>
> Maybe a better approach is: we can delete the scheduling-request.allowed in
> CS, and update placement-constraints configs in yarn-site.xml a bit:
>
> - Remove placement-constraints.enabled, and add a new
> placement-constraints.handler, by default is none, and other acceptable
> values are a. external-processor (since algorithm is too generic to me), b.
> scheduler.
> - And add a new PlacementProcessor just to pass SchedulingRequest to
> scheduler without any modifications.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
