[
https://issues.apache.org/jira/browse/YARN-7328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363536#comment-16363536
]
lovekesh bansal commented on YARN-7328:
---------------------------------------
[~templedf] [~leftnoteasy] I think some of the things have changed since when
the Jira was filed:
# We are currently throwing that exception in checkMandatoryResources for if
it contains memory. By making this change we will be limiting it to be defined
in both resource-types.xml and node-resources.xml. Is that the intent here?
# Now we have some more reosurces in MANDATORY_RESOURCES, so should not allow
of them to be defined in node-resources.xml?
# ResourceUtils.getNodeResourceInformation(conf) is called by
NodeManagerHardwareUtils.
getNodeResources which after calling function checks if(memResInfo.getValue()
== 0) \{ret.setMemorySize(getContainerMemoryMB(conf))}
So then if check would become redundant and we would always be setting the
memory by calling
ret.setMemorySize(getContainerMemoryMB(conf)) .
Let me know your thoughts?
> ResourceUtils allows yarn.nodemanager.resource-types.memory-mb and .vcores to
> override yarn.nodemanager.resource.memory-mb and .cpu-vcores
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-7328
> URL: https://issues.apache.org/jira/browse/YARN-7328
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 3.1.0
> Reporter: Daniel Templeton
> Priority: Critical
>
> We will throw an exception if yarn.nodemanager.resource-types.memory is
> configured, but not if .memory-mb or .vcores is configured. We should be
> consistent. We should not allow resource types to redefine something for
> which we already have a property to set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
