[ 
https://issues.apache.org/jira/browse/YARN-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754336#comment-13754336
 ] 

Junping Du commented on YARN-771:
---------------------------------

Hi [~bikassaha], Thanks for good comments above. 
I have different ideas here that I thought every results are determinate so far.
case 1: app add node-a to addition list and then add it to removal list (tends 
to remove it).
{code}
client.updateBlacklist(a, null);
client.updateBlacklist(null, a);
client.schedule();
//{a,a} will be sent, and a will not in blacklist
{code}

case 2: app add node-a to removal list and then add node-a to addition list 
(tends to add node-a back to blacklist)
{code}
client.updateBlacklist(null, a);
client.updateBlacklist(a, null);
client.schedule();
//(a, null) will be sent, so a will be in blacklist
{code}

case 3: app add node-a to removal list and addition list at the same call.
{code}
client.updateBlacklist(a, a);
client.schedule();
//{a, a} will be sent and a will not in blacklist
{code}

I understand there are different opinions around case 3 that it leads to user 
confused to mean "I want node-a in blacklist" or "I want node-a not in 
blacklist". My question is: can this confusion be resolved through proper 
documentation?
Map to real cases, the previous one may come from case which seems rare to me - 
app said "I want to remove nodes from blacklist in set R except it is in set A 
(assume node-a in both set A and set R)". But the latter one may come from more 
often case - app said "I want nodes from set A go to blacklist except it is in 
set R (node-a in both sets)". We can better support latter case here rather 
than updateBlacklist twice. Thoughts? 

                
> AMRMClient  support for resource blacklisting
> ---------------------------------------------
>
>                 Key: YARN-771
>                 URL: https://issues.apache.org/jira/browse/YARN-771
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Junping Du
>         Attachments: YARN-771-v1.0.patch, YARN-771-v2.patch, YARN-771-v3.patch
>
>
> After YARN-750 AMRMClient should support blacklisting via the new YARN API's

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to