[
https://issues.apache.org/jira/browse/YARN-6528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377902#comment-16377902
]
Giovanni Matteo Fumarola commented on YARN-6528:
------------------------------------------------
Thanks [~lxhfirenking] for the patch. I am taking over the review from
[~botong].
I looked at it and have a few minor comments:
* The patch does not test the correctness of {{ReservationQueueMetrics}}.
Please add some unit tests for it.Take a look of {{TestRouterMetrics}} for this
comment.
* Why do you need InterfaceAudience and InterfaceStability in
{{package-info.java}}?
* NIT: {{ReservationQueueMetrics}} has a different style for license from
other classes.
* NIT: Please add javadoc for {{ReservationQueueMetrics}}#{{sourceName}}.
* NIT: Please add the about field in {{ReservationQueueMetrics}}. It will give
more details on jmx.
e.g.
{code:java}
@Metrics(about= "Metrics ......", context = "yarn")
{code}
* NIT: {{reservationQueueMetrics}} in {{InMemoryPlan}} should be the last
param.
* NIT: {{getRootQueueReservationMetrics}} in {{CapacityReservationSystem}},
{{FairReservationSystem}}, {{YarnScheduler}} and {{AbstractCSQueue}} should be
the last method.
* NIT: {{getReservationQueueMetrics}} in {{PlanContext}} and
{{CapacityScheduler}} should be the last method.
* NIT: Move {{reservationQueueMetrics}} after {{queueEntity}} in
{{AbstractCSQueue}}.
* NIT: Move {{rootReservationMetrics}} after {{fsOpDurations}} in
{{FairScheduler}}.
The last 5 comments are just to avoid future conflicts.
> [PERF/TEST] Add JMX metrics for Plan Follower and Agent Placement and Plan
> Operations
> -------------------------------------------------------------------------------------
>
> Key: YARN-6528
> URL: https://issues.apache.org/jira/browse/YARN-6528
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sean Po
> Assignee: Xiaohua (Victor) Liang
> Priority: Major
> Attachments: YARN-6528.v001.patch, YARN-6528.v002.patch,
> YARN-6528.v003.patch, YARN-6528.v004.patch, YARN-6528.v005.patch,
> YARN-6528.v006.patch, YARN-6528.v007.patch, YARN-6528.v008.patch,
> YARN-6528.v009.patch, YARN-6528.v010.patch, YARN-6528.v011.patch
>
>
> YARN-1051 introduced a ReservationSytem that enables the YARN RM to handle
> time explicitly, i.e. users can now "reserve" capacity ahead of time which is
> predictably allocated to them. In order to understand in finer detail the
> performance of Rayon, YARN-6528 proposes to include JMX metrics in the Plan
> Follower, Agent Placement and Plan Operations components of Rayon.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
