[
https://issues.apache.org/jira/browse/YARN-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379546#comment-16379546
]
Giovanni Matteo Fumarola edited comment on YARN-7707 at 2/28/18 12:25 AM:
--------------------------------------------------------------------------
Thanks [~youchen] for the patch. I took a quick look and I have few starting
comments:
*YarnConfiguration*
* Can you add a new prefix FEDERATION_GPG_POLICY_PREFIX for
FEDERATION_GPG_PREFIX + "policy.generator"?
*pom.xml*
* Why do you need {{hadoop-yarn-server-timelineservice}}?
*GPGUtils*
* The javadoc comment should be different for {{createUniformWeights}}.
*DefaultGlobalPolicy*
* Can you improve the javadoc of it?
* You add a log line and it says "Updating..." but you just return null. There
will be some confusion in the logs. Please change to something else.
*package-info.java*
* Add javadoc for it.
*UniformWeightedLocalityGlobalPolicy*
* Line 50 and 52 are identical.
Please revisit all the javadoc in {{PolicyGenerator}} and {{GPGPolicyFacade}}.
You use {{state store}} in few comments, can you change to
{{FederationStateStore}} to avoid confusion with ZK StateStore.
was (Author: giovanni.fumarola):
Thanks [~youchen] for the patch. I took a quick look and I have few starting
comments:
*pom.xml*
* Why do you need {{hadoop-yarn-server-timelineservice}}?
*GPGUtils*
* The javadoc comment should be different for {{createUniformWeights}}.
*DefaultGlobalPolicy*
* Can you improve the javadoc of it?
* You add a log line and it says "Updating..." but you just return null. There
will be some confusion in the logs. Please change to something else.
*package-info.java*
* Add javadoc for it.
*UniformWeightedLocalityGlobalPolicy*
* Line 50 and 52 are identical.
Please revisit all the javadoc in {{PolicyGenerator}} and {{GPGPolicyFacade}}.
You use {{state store}} in few comments, can you change to
{{FederationStateStore}} to avoid confusion with ZK StateStore.
> [GPG] Policy generator framework
> --------------------------------
>
> Key: YARN-7707
> URL: https://issues.apache.org/jira/browse/YARN-7707
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Carlo Curino
> Assignee: Young Chen
> Priority: Major
> Labels: federation, gpg
> Attachments: YARN-7707-YARN-7402.01.patch,
> YARN-7707-YARN-7402.02.patch, YARN-7707-YARN-7402.03.patch,
> YARN-7707-YARN-7402.04.patch, YARN-7707-YARN-7402.05.patch,
> YARN-7707-YARN-7402.06.patch
>
>
> This JIRA tracks the development of a generic framework for querying
> sub-clusters for metrics, running policies, and updating them in the
> FederationStateStore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
