[ https://issues.apache.org/jira/browse/YARN-5015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390106#comment-16390106 ]
Chandni Singh commented on YARN-5015: ------------------------------------- [~leftnoteasy] I have updated the description. I have followed [~vvasudev] suggestions {quote}I think you probably need to change your approach if we want to unify the AM and container restart policies. I think what's required is a common class - something like SlidingWindowContainerRetryPolicy or something like that which takes a SlidingWindowContainerRetryContext consisting of the restart timestamps, the validity interval, the exit codes, the exit codes to ignore, and the remaining retry attempts. The SlidingWindowContainerRetryPolicy can then look at the various parameters and tell you whether to retry the container or not. {quote} > Support sliding window retry capability for container restart > -------------------------------------------------------------- > > Key: YARN-5015 > URL: https://issues.apache.org/jira/browse/YARN-5015 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Reporter: Varun Vasudev > Assignee: Chandni Singh > Priority: Major > Labels: oct16-medium > Attachments: YARN-5015.01.patch, YARN-5015.02.patch, > YARN-5015.03.patch > > > We support sliding window retry policy for AM restarts. Similar sliding > window retry policy is needed for container restarts. > With this change, we can introduce a common class for > SlidingWindowRetryPolicy ( suggested by [~vvasudev] in the comments) and > integrate it to container restart. > In a subsequent jira, we can modify the AM code to use > SlidingWindowRetryPolicy which will unify the AM and container restart code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org