[ https://issues.apache.org/jira/browse/YARN-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755864#comment-13755864 ]
Vinod Kumar Vavilapalli commented on YARN-1120: ----------------------------------------------- It took a while for me to really understand what this issue was about. Luckily I was involved in all of the referenced tickets and your description is all too compact but perfect :) The patch looks good to me, +1. Checking this in. > Make ApplicationConstants.Environment.USER definition OS neutral > ---------------------------------------------------------------- > > Key: YARN-1120 > URL: https://issues.apache.org/jira/browse/YARN-1120 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Chuan Liu > Assignee: Chuan Liu > Priority: Minor > Attachments: YARN-1120.patch > > > In YARN-557, we added some code to make {{ > ApplicationConstants.Environment.USER}} has OS-specific definition in order > to fix the unit test TestUnmanagedAMLauncher. In YARN-571, the relevant test > code was corrected. In YARN-602, we actually will explicitly set the > environment variables for the child containers. With these changes, I think > we can revert the YARN-557 change to make {{ > ApplicationConstants.Environment.USER}} OS neutral. The main benefit is that > we can use the same method over the Enum constants. This should also fix the > TestContainerLaunch#testContainerEnvVariables failure on Windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira