[ https://issues.apache.org/jira/browse/YARN-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399777#comment-16399777 ]
Weiwei Yang edited comment on YARN-8002 at 3/15/18 2:37 AM: ------------------------------------------------------------ Thanks [~leftnoteasy] bq. Changes in SingleConstraintAppPlacementAllocato... The allocator should be able to support all namespace types except app-label. I have added test case {{TestSchedulingRequestContainerAllocation#testInterAppAntiAffinity}} to verify simple anti-affinity inter-app constraints, and for comprehensive tests over different namespace types, that can be found in {{TestPlacementConstraintsUtil}}. The ultimate goal is to support all of these types ASAP, and I can write more tests in YARN-8015. bq. TargetApplications: remove unused methods Done bq. aggregateAllocationTagsByApps/aggregateAllocationTagsByRac --- The two methods can be merged. Good suggestion, I've merged them to one method now. About the null check, I prefer to keep it in case in future this method is used in some where else. Just to prevent a potential NPE. bq. getNamespaceScope ... remove those OK, I have removed those and replaced by explicit check on enum value. bq. I suggest to add a method like throwExceptionIfNamespaceTypeNotSupported so we don't need to change all the places in the future. That might not be necessary. There are two checks, one in {{PlacementConstraintsUtil}} and the other in {{SingleConstraintAppPlacementAllocator}}. I will removed the first one once YARN-8013 is done. And removed the 2nd one once YARN-8015 is done. But please let me know if you insist on this, I can add a method in {{PlacementConstraintsUtil}} and call it in both places. I will upload a new patch shortly. Thanks was (Author: cheersyang): Thanks [~leftnoteasy] bq. Changes in SingleConstraintAppPlacementAllocato... Make sense, I have removed the change in this patch. Will track in YARN-8015. bq. TargetApplications: remove unused methods Done bq. aggregateAllocationTagsByApps/aggregateAllocationTagsByRac --- The two methods can be merged. Good suggestion, I've merged them to one method now. About the null check, I prefer to keep it in case in future this method is used in some where else. Just to prevent a potential NPE. bq. getNamespaceScope ... remove those OK, I have removed those and replaced by explicit check on enum value. bq. I suggest to add a method like throwExceptionIfNamespaceTypeNotSupported so we don't need to change all the places in the future. That might not be necessary. There are two checks, one in {{PlacementConstraintsUtil}} and the other in {{SingleConstraintAppPlacementAllocator}}. I will removed the first one once YARN-8013 is done. And removed the 2nd one once YARN-8015 is done. But please let me know if you insist on this, I can add a method in {{PlacementConstraintsUtil}} and call it in both places. I will upload a new patch shortly. Thanks > Support NOT_SELF and ALL namespace types for allocation tag > ----------------------------------------------------------- > > Key: YARN-8002 > URL: https://issues.apache.org/jira/browse/YARN-8002 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Weiwei Yang > Assignee: Weiwei Yang > Priority: Major > Attachments: YARN-8002.001.patch, YARN-8002.002.patch, > YARN-8002.003.patch > > > This is a continua task after YARN-7972, YARN-7972 adds support to specify > tags with namespace SELF and APP_ID, like following > * self/<tag> > * app-id/<appid>/<tag> > this task is to track the work to support 2 of remaining namespace types > *NOT_SELF* & *ALL* (we'll support app-label later), > * not-self/<tag> > * all/<tag> > this will require a bit refactoring in {{AllocationTagsManager}} as it needs > to do some proper aggregation on tags for multiple apps. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org