[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403482#comment-16403482 ]
Haibo Chen commented on YARN-7581: ---------------------------------- {quote}someone wanted to see their megabytemillis counter value, do we need to retrieve the info field in that case? {quote} According to the comment in every TimelineEntityReader subclass, "// By default fetch everything in INFO column family.", info fields are always retrieved. I assume that is for good reasons. Hence, I added info family to cfsInFields. {quote} Any reason we are explicitly defining convertBytesToString and convertStringToBytes instead of using the ones that HBase provides? {quote} Good point. I was not aware of Bytes.toString(byte[]). Will update the patch to reuse Bytes.toString(byte[]) and Bytes.toBytes(String). > HBase filters are not constructed correctly in ATSv2 > ---------------------------------------------------- > > Key: YARN-7581 > URL: https://issues.apache.org/jira/browse/YARN-7581 > Project: Hadoop YARN > Issue Type: Sub-task > Components: ATSv2 > Affects Versions: 3.0.0-beta1 > Reporter: Haibo Chen > Assignee: Haibo Chen > Priority: Major > Attachments: YARN-7581-YARN-7055.04.patch, YARN-7581.00.patch, > YARN-7581.01.patch, YARN-7581.02.patch, YARN-7581.03.patch, YARN-7581.04.patch > > > Post YARN-7346, > TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesConfigFilters() and > TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesMetricFilters() > start to fail when hbase.profile is set to 2.0) > *Error Message* > [ERROR] Failures: > [ERROR] > TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesConfigFilters:1266 > expected:<2> but was:<0> > [ERROR] > TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesMetricFilters:1523 > expected:<1> but was:<0> -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org