[ 
https://issues.apache.org/jira/browse/YARN-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407267#comment-16407267
 ] 

Wangda Tan commented on YARN-8016:
----------------------------------

Thanks [~Zian Chen], a quick comment: 

{code}
1004      private String buildQueueMappingRuleProperty (String 
queueMappingSuffix) {
1005        StringBuilder queueMapping = new StringBuilder();
1006        
queueMapping.append(QUEUE_MAPPING).append(".").append(queueMappingSuffix);
1007        return queueMapping.toString();
1008      }
{code}

Which makes per-policy-configuration load from 
{{yarn.scheduler.capacity.queue-mappings.app-name.*}} 

However, since the {{yarn.scheduler.capacity.queue-mappings}} is added because 
of historical reason, it's only purpose is to support user-group mapping. I 
think we should not override it.

So instead of using {{QUEUE_MAPPING}}, I prefer to change to use 
{{YarnConfiguration#QUEUE_PLACEMENT_RULES}}, so the configuration becomes: 

{code}
yarn.scheduler.queue-placement-rules.app-name.*
{code}

There's no need to change UserGroupMapping policy to read config from the new 
name. 

And I found in the CS.md, it doesn't mention 
{{yarn.scheduler.queue-placement-rules}}, we should cleanup existing doc a bit, 
maybe start a separate file and move all queue-mapping related topics to the 
new file. Which can be done in a separate JIRA.

> Refine PlacementRule interface and add a app-name queue mapping rule as an 
> example
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-8016
>                 URL: https://issues.apache.org/jira/browse/YARN-8016
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Zian Chen
>            Assignee: Zian Chen
>            Priority: Major
>         Attachments: YARN-8016.001.patch, YARN-8016.002.patch, 
> YARN-8016.003.patch
>
>
> After YARN-3635/YARN-6689, PlacementRule becomes a common interface which can 
> be used by scheduler and can be dynamically updated by scheduler according to 
> configs. There're some other works. 
> - There's no way to initialize PlacementRule.
> - No example of PlacementRule except the user-group mapping one.
> This JIRA is targeted to refine PlacementRule interfaces and add another 
> PlacementRule example.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to