[ 
https://issues.apache.org/jira/browse/YARN-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411869#comment-16411869
 ] 

Eric Yang commented on YARN-8032:
---------------------------------

The value is set to -1 regardless what value that is passed through the CLI 
during my test. I change the code like this:
{code:java}
+++ 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/containerlaunch/AbstractLau
@@ -169,10 +169,12 @@ public ContainerLaunchContext completeContainerLaunch() 
throws IOException {
     return containerLaunchContext;
   }
 
-  public void setRetryContext(int maxRetries, int retryInterval) {
+  public void setRetryContext(int maxRetries, int retryInterval,
+      long failuresValidityInterval) {
+    log.info("failure validity interval {}", failuresValidityInterval);
     ContainerRetryContext retryContext = ContainerRetryContext
-        .newInstance(ContainerRetryPolicy.RETRY_ON_ALL_ERRORS, null, 
maxRetries,
-            retryInterval);
+        .newInstance(ContainerRetryPolicy.RETRY_ON_ALL_ERRORS, null,
+            maxRetries, retryInterval, failuresValidityInterval);
     containerLaunchContext.setContainerRetryContext(retryContext);
   }
{code}
I think there is a gap that not all properties are set in AM environment as 
intended.

> Yarn service should expose failuresValidityInterval to users and use it for 
> launching containers
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8032
>                 URL: https://issues.apache.org/jira/browse/YARN-8032
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>            Priority: Major
>         Attachments: YARN-8032.001.patch, YARN-8032.002.patch, 
> YARN-8032.003.patch
>
>
> With YARN-5015 the support for sliding window retry policy was added. Yarn 
> service should expose it via the api for the users to take advantage of it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to