[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416480#comment-16416480
]
Wangda Tan commented on YARN-8048:
----------------------------------
Thanks [~rohithsharma],
1) createServiceManager: Why make this configurable? I think we should hardcode
this one unless we have any use case requires pluggability.
2) SystemServiceManager:
2.1 Why mkdir if it is absent?
{code}
if (!fs.exists(systemServiceDir)) {
fs.mkdirs(systemServiceDir);
fs.setPermission(systemServiceDir, SYSTEM_SERVICE_DIR_PERMISSION);
}
{code}
I think we should skip system services if the folder doesn't exist.
2.2 (related) Why 777 permission?
2.3 scanForUserServiceDefinition:
- It's better to make user name(s) configurable in yarn-site.xml . Otherwise
some user could put some random folders which is recognized as user name and
cause failure/security issues.
- For the 2nd level, it's better to only read files ended with .yarnfile.
2.4 I'm not sure if we should make system service launch asynchronized or
synchronized. To me it makes more sense to launch synchronized.
Renames:
- ServiceManager => SystemServiceManager (add javadocs)
- SystemServiceManager => ()Impl
> Support auto-spawning of admin configured services during bootstrap of
> rm/apiserver
> -----------------------------------------------------------------------------------
>
> Key: YARN-8048
> URL: https://issues.apache.org/jira/browse/YARN-8048
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Priority: Major
> Attachments: YARN-8048.001.patch, YARN-8048.002.patch,
> YARN-8048.003.patch, YARN-8048.004.patch
>
>
> Goal is to support auto-spawning of admin configured services during
> bootstrap of resourcemanager/apiserver.
> *Requirement:* Some of the services might required to be consumed by yarn
> itself ex: Hbase for atsv2. Instead of depending on user installed HBase or
> sometimes user may not required to install HBase at all, in such conditions
> running HBase app on YARN will help for ATSv2.
> Before YARN cluster is started, admin configure these services spec and place
> it in common location in HDFS. At the time of RM/apiServer bootstrap, these
> services will be submitted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
