[
https://issues.apache.org/jira/browse/YARN-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758666#comment-13758666
]
Vinod Kumar Vavilapalli commented on YARN-1070:
-----------------------------------------------
The argument is reasonable.
bq. On the other side, if at this point the container state is still LOCALIZED,
call() will move on. Then, if the container state changes to KILLING in the
midway, we just ignore it let call() finish as usual. It does no harm because
when the container reaches KILLING, CLEANUP_CONTAINER is scheduled or is
started.
We do have one more check just before we launch the process. We should do the
same stack-check there too.
Also, as part of ContainerLaunch.cleanupContainer(), we should try to cancel
the Callable.
Taking a step back, this approach will work, though the code is hard to read
for me. A very simple state machine should make this code a lot cleaner.
> ContainerImpl State Machine: Invalid event: CONTAINER_KILLED_ON_REQUEST at
> CONTAINER_CLEANEDUP_AFTER_KILL
> ---------------------------------------------------------------------------------------------------------
>
> Key: YARN-1070
> URL: https://issues.apache.org/jira/browse/YARN-1070
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Hitesh Shah
> Assignee: Zhijie Shen
> Attachments: YARN-1070.1.patch, YARN-1070.2.patch, YARN-1070.3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
