[ 
https://issues.apache.org/jira/browse/YARN-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420710#comment-16420710
 ] 

Sunil G commented on YARN-7875:
-------------------------------

Thanks [~bibinchundatt]. Few comments.
 # Test case failure seems related.
 # javadoc error also related likeĀ NodeAttributeStore needs more java doc.
 # Could you please rename {{org/apache/hadoop/yarn/nodelabels/store/op}} to 
{{org/apache/hadoop/yarn/nodelabels/store/operations}}
 # More test cases for adding/removing/replacing attributes on one 
node/multiple node and finally verifying with getter api.

> AttributeStore for store and recover attributes
> -----------------------------------------------
>
>                 Key: YARN-7875
>                 URL: https://issues.apache.org/jira/browse/YARN-7875
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Major
>         Attachments: YARN-7875-WIP.patch, YARN-7875-YARN-3409.001.patch, 
> YARN-7875-YARN-3409.002.patch, YARN-7875-YARN-3409.003.patch
>
>
> Similar to NodeLabelStore need to support NodeAttributeStore for persisting 
> attributes mapping to Nodes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to