[ 
https://issues.apache.org/jira/browse/YARN-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423579#comment-16423579
 ] 

Weiwei Yang commented on YARN-8111:
-----------------------------------

Hi [~kkaranasos]

Thanks for the quick review,
{quote}I suggest to keep the allocationTagToIntraApp so that we can later 
easily change the default behavior if we want
{quote}
Note, the {{PlacementConstraints#allocationTagToIntraApp}} currently is only 
used in UT code. For simplify the API purpose, it's a good chance to remove it. 
Otherwise won't it cause confusing? People will ask if I want to create 
inter-app tags, should I use #allocationTag or #allocationTagToIntraApp?

Please let me know if this makes sense.

Thanks.

> Simplify PlacementConstraints class API
> ---------------------------------------
>
>                 Key: YARN-8111
>                 URL: https://issues.apache.org/jira/browse/YARN-8111
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Minor
>         Attachments: YARN-8111.001.patch
>
>
> # Per discussion in YARN-8013, we agree to disallow null value for namespace 
> and default it to SELF.
>  # Remove PlacementConstraints#allocationTagToIntraApp



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to