[
https://issues.apache.org/jira/browse/YARN-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423929#comment-16423929
]
Weiwei Yang commented on YARN-7764:
-----------------------------------
Hi [~sunilg]
If return a copy is not an option, I tried to modify the signature to return an
unmodified list, but that ends up with modifying too many classes. In this
case, I suggest to exclude this check in findbugs as it is intended. The caller
needs to make sure there is no modifications to the ResourceInformation array
returned by getResources. Uploaded v2 patch.
Please let me know your thoughts.
Thanks
> Findbugs warning: Resource#getResources may expose internal representation
> --------------------------------------------------------------------------
>
> Key: YARN-7764
> URL: https://issues.apache.org/jira/browse/YARN-7764
> Project: Hadoop YARN
> Issue Type: Bug
> Components: api
> Affects Versions: 3.0.0, 3.1.0
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Labels: findbugs
> Attachments: YARN-7764.001.patch, YARN-7764.002.patch
>
>
> Hadoop qbt report:
> {noformat}
> FindBugs :
> module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
> org.apache.hadoop.yarn.api.records.Resource.getResources() may expose
> internal representation by returning Resource.resources At Resource.java:by
> returning Resource.resources At Resource.java:[line 234]
> {noformat}
> Introduced by YARN-7136.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
