[
https://issues.apache.org/jira/browse/YARN-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424332#comment-16424332
]
Vrushali C commented on YARN-8073:
----------------------------------
Hi [~rohithsharma]
thanks for the latest patch! LGTM, pending two minor changes as suggested by
checkstyle.
{code}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:3792:
public static boolean timelineServiceV1_5Enabled(Configuration conf) {:25:
Name 'timelineServiceV1_5Enabled' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[MethodName]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java:85:
private boolean timelineServiceV1_5Enabled;:19: Name
'timelineServiceV1_5Enabled' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[MemberName]
{code}
I think we might want to rename the method and variable as per checkstyle
suggestions.
> TimelineClientImpl doesn't honor yarn.timeline-service.versions configuration
> -----------------------------------------------------------------------------
>
> Key: YARN-8073
> URL: https://issues.apache.org/jira/browse/YARN-8073
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Priority: Major
> Attachments: YARN-8073.01.patch, YARN-8073.02.patch
>
>
> Post YARN-6736, RM support writing into ats v1 and v2 by new configuration
> setting _yarn.timeline-service.versions_.
> Couple of issues observed in deployment are
> # TimelineClientImpl doesn't honor newly added configuration rather it still
> get version number from _yarn.timeline-service.version_. This causes not
> writing into v1.5 API's even though _yarn.timeline-service.versions has 1.5
> value._
> # Similar line from 1st point, TimelineUtils#timelineServiceV1_5Enabled
> doesn't honor timeline-service.versions.
> # JobHistoryEventHandler#serviceInit(), line no 271 check for version number
> rather than calling YarnConfiguration#timelineServiceV2Enabled
> cc :/ [~agresch]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
