[
https://issues.apache.org/jira/browse/YARN-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yufei Gu updated YARN-8162:
---------------------------
Description: First of all, DirectoryCollection#verifyDirUsingMkdir doesn't
do what it claims to do, it creates a file but its Java doc says it create a
dir. Because of that, it doesn't compatible with {{ReadWriteDiskValidator}}
because the validator will throw an exception if it isn't dir. What's more, it
is no longer needed after HADOOP-13738 (DiskChecker should perform some disk
IO). It duplicates what HADOOP-13738 does. We should remove it. (was: First
of all, DirectoryCollection#verifyDirUsingMkdir doesn't do what it claims to
do, it creates a file but its Java doc says it create a dir. What's more, it is
no longer needed after HADOOP-13738 (DiskChecker should perform some disk IO).
It duplicates what HADOOP-13738 does. We should remove it.)
> Method DirectoryCollection#verifyDirUsingMkdir isn't needed anymore
> -------------------------------------------------------------------
>
> Key: YARN-8162
> URL: https://issues.apache.org/jira/browse/YARN-8162
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.1.0
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Priority: Major
> Attachments: YARN-8162.001.patch
>
>
> First of all, DirectoryCollection#verifyDirUsingMkdir doesn't do what it
> claims to do, it creates a file but its Java doc says it create a dir.
> Because of that, it doesn't compatible with {{ReadWriteDiskValidator}}
> because the validator will throw an exception if it isn't dir. What's more,
> it is no longer needed after HADOOP-13738 (DiskChecker should perform some
> disk IO). It duplicates what HADOOP-13738 does. We should remove it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
