[ https://issues.apache.org/jira/browse/YARN-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441221#comment-16441221 ]
Yufei Gu commented on YARN-7966: -------------------------------- Thank [~Sen Zhao] for woking on this. Looks good to me overall. Could you remove the unused imports? > Remove AllocationConfiguration#getQueueAcl and related unit test > ---------------------------------------------------------------- > > Key: YARN-7966 > URL: https://issues.apache.org/jira/browse/YARN-7966 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler > Affects Versions: 3.1.0 > Reporter: Yufei Gu > Assignee: Sen Zhao > Priority: Minor > Labels: newbie++ > Attachments: YARN-7966.001.patch > > > AllocationConfiguration#getQueueAcl isn't needed any more after YARN-4997. We > should remove it and its related unit test. All its logic is reimplemented in > AllocationFileLoaderService#getDefaultPermissions. class > AllocationConfiguration doesn't have any API annotation, it is considered as > private. So it is OK to remove its public method. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org