[ 
https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442403#comment-16442403
 ] 

BELUGA BEHR commented on YARN-8169:
-----------------------------------

[~leftnoteasy]

Parameters are best for slf4j:

# Avoids double-checking the 'debug enabled' flag
# Faster than run-time String concatenation
# Less code clutter
# Produces smaller product binary (saves memory and execution cache)

https://www.slf4j.org/faq.html#logging_performance

> Review RackResolver.java
> ------------------------
>
>                 Key: YARN-8169
>                 URL: https://issues.apache.org/jira/browse/YARN-8169
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn
>    Affects Versions: 3.0.1
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: YARN-8169.1.patch
>
>
> # Use SLF4J
> # Fix some checkstyle warnings
> # Minor clean up



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to