[
https://issues.apache.org/jira/browse/YARN-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447024#comment-16447024
]
ASF GitHub Bot commented on YARN-8057:
--------------------------------------
Github user lzh3636 commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/362#discussion_r183220591
--- Diff:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
---
@@ -124,11 +124,11 @@ protected synchronized void
cleanupRunningContainers() {
} catch (YarnException e) {
LOG.error("Failed to stop Container " +
startedContainer.getContainerId() +
- "when stopping NMClientImpl");
+ "when stopping NMClientImpl", e);
--- End diff --
If there's no "e", the log here will only show the message "Failed to stop
Container ### when stopping NMClientImpl". People will only know there's
something wrong here, but will not know what's wrong here. (YarnException?
IOException?)
If add an "e" here, the exception type and position where this exception
happens will also be generated to the log, so that people will know what's
wrong here.
> Inadequate information for handling catch clauses
> -------------------------------------------------
>
> Key: YARN-8057
> URL: https://issues.apache.org/jira/browse/YARN-8057
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: api, yarn
> Affects Versions: 3.0.0
> Reporter: Zhenhao Li
> Priority: Major
> Labels: easyfix
>
> Their are some situations that different exception types are caught, but the
> handling of those exceptions can not show the differences of those types.
> Here are the code snippets we found which have this problem:
> *org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java*
> [https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java]
> At Line *125* and Line *129.* We can see that two exception types are caught,
> but the logging statements here can not show the exception type at all. It
> may cause confusions to the person who is reading the log, the person can not
> know what exception happened here.
>
> Maybe adding stack trace information to these two logging statements is a
> simple way to improve it.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
