[
https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465285#comment-16465285
]
Haibo Chen commented on YARN-7715:
----------------------------------
I think the new patch would still call updateContainer() even when the
container is not running. I was thinking of something along the lines of
{code:java}
if (updateEvent.isIncrease()) {
// Promotion of queued container..
if (queuedOpportunisticContainers.remove(containerId) != null) {
...
} else {
resourceHandlerChain.updateContainer(container);
}
} else {
if (queuedGuaranteedContainers.remove(containerId) != null) {
queuedOpportunisticContainers.put(containerId,
updateEvent.getContainer());
} else {
resourceHanlderChain.updateContainer(container);
}
}{code}
TestContainerSchedulerQueuing does container tests for container
promotion/demotion. How about we mock the resourceHandlerChain and verify the
method call?
> Update CPU and Memory cgroups params on container update as well.
> -----------------------------------------------------------------
>
> Key: YARN-7715
> URL: https://issues.apache.org/jira/browse/YARN-7715
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Arun Suresh
> Assignee: Miklos Szegedi
> Priority: Major
> Attachments: YARN-7715.000.patch, YARN-7715.001.patch,
> YARN-7715.002.patch
>
>
> In YARN-6673 and YARN-6674, the cgroups resource handlers update the cgroups
> params for the containers, based on opportunistic or guaranteed, in the
> *preStart* method.
> Now that YARN-5085 is in, Container executionType (as well as the cpu, memory
> and any other resources) can be updated after the container has started. This
> means we need the ability to change cgroups params after container start.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
