[ https://issues.apache.org/jira/browse/YARN-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469398#comment-16469398 ]
Haibo Chen commented on YARN-8250: ---------------------------------- This is based on UpdateContainerTokenEvent. There are four combinations possible. If isResourceChange() returns true, then it is a container resizing request. It is a container resource increase if isIncrease() return true. If isExecTypeUpdate() returns true, then it is a container promotion/demotion request. It's a promotion is isIncrease() return true. isDecrease() is implied to be true if isIncrease() returns false. See UpdateContainerTokenEvent.java. Hence, not much we could do here. While I agree with you that the code can be improved to avoid such confusion, I'd leave that to a different jira. > Create another implementation of ContainerScheduler to support NM > overallocation > -------------------------------------------------------------------------------- > > Key: YARN-8250 > URL: https://issues.apache.org/jira/browse/YARN-8250 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Haibo Chen > Assignee: Haibo Chen > Priority: Major > Attachments: YARN-8250-YARN-1011.00.patch, > YARN-8250-YARN-1011.01.patch, YARN-8250-YARN-1011.02.patch > > > YARN-6675 adds NM over-allocation support by modifying the existing > ContainerScheduler and providing a utilizationBased resource tracker. > However, the implementation adds a lot of complexity to ContainerScheduler, > and future tweak of over-allocation strategy based on how much containers > have been launched is even more complicated. > As such, this Jira proposes a new ContainerScheduler that always launch > guaranteed containers immediately and queues opportunistic containers. It > relies on a periodical check to launch opportunistic containers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org