[ https://issues.apache.org/jira/browse/YARN-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469598#comment-16469598 ]
Naganarasimha G R commented on YARN-7892: ----------------------------------------- [~bibinchundatt] & [~sunilg] * Checkstyle issues remaining are the ones which cannot be directly fixed. * white space could be corrected when committing the patch using "–whitespace=fix" option * Test case failure(TestPlacementConstraintTransformations) occurs even without the patch, * ASF license issue is not related to the modifications in the patch. Thus i think its ready for commit, Please check and confirm if anything else needs to be modified. > Revisit NodeAttribute class structure > ------------------------------------- > > Key: YARN-7892 > URL: https://issues.apache.org/jira/browse/YARN-7892 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Naganarasimha G R > Assignee: Naganarasimha G R > Priority: Major > Attachments: YARN-7892-YARN-3409.001.patch, > YARN-7892-YARN-3409.002.patch, YARN-7892-YARN-3409.003.WIP.patch, > YARN-7892-YARN-3409.003.patch, YARN-7892-YARN-3409.004.patch, > YARN-7892-YARN-3409.005.patch, YARN-7892-YARN-3409.006.patch, > YARN-7892-YARN-3409.007.patch, YARN-7892-YARN-3409.008.patch, > YARN-7892-YARN-3409.009.patch > > > In the existing structure, we had kept the type and value along with the > attribute which would create confusion to the user to understand the APIs as > they would not be clear as to what needs to be sent for type and value while > fetching the mappings for node(s). > As well as equals will not make sense when we compare only for prefix and > name where as values for them might be different. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org