[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471744#comment-16471744 ]
Rohith Sharma K S commented on YARN-7933: ----------------------------------------- bq. probably we can remove the change to TimelineEntity.java and leave it to the other jira Make sense.. done bq. Do you see any downside of removing appId from the query? If not, How about we get rid of the appId param? As discussed in weekly call between myself Vrushali and Haibo, we thought to get rid of appId. But later after looking code, currently collectors are specific to application. If application finished, there will no corresponding collector exist. So, without appId, we don't get collectors info which doesn't allow to write into to backend. We should need appId in query to identify corresponding collectors. > [atsv2 read acls] Add TimelineWriter#writeDomain > ------------------------------------------------- > > Key: YARN-7933 > URL: https://issues.apache.org/jira/browse/YARN-7933 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Vrushali C > Assignee: Rohith Sharma K S > Priority: Major > Attachments: YARN-7933.01.patch, YARN-7933.02.patch, > YARN-7933.03.patch, YARN-7933.04.patch > > > > Add an API TimelineWriter#writeDomain for writing the domain info -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org