[ https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472335#comment-16472335 ]
Haibo Chen commented on YARN-8248: ---------------------------------- Thanks [~snemeth] for the clarification. I think in general it's okay for fix some minor code/style cleanup around the same area while working on a patch. It becomes however, overhead if the minor changes cause confusion, or is to remote to your core change. Folks reading the commit history would also have questions, without digging into the Jira discussion. Hence, I'd prefer, in this case, to leave Resources as is. If there are many cleanup issues you can find, a separate patch is justifiable. I agree with you debug logs help debugging, especially on the unhappy/abnormal code path. However, if we add too much logging on the happy hot code path, the logs will be flooded. > Job hangs when queue is specified and that queue has 0 capability of a > resource > ------------------------------------------------------------------------------- > > Key: YARN-8248 > URL: https://issues.apache.org/jira/browse/YARN-8248 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler, yarn > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-8248-001.patch, YARN-8248-002.patch, > YARN-8248-003.patch, YARN-8248-004.patch, YARN-8248-005.patch > > > Job hangs when mapreduce.job.queuename is specified and the queue has 0 of > any resource (vcores / memory / other) > In this scenario, the job should be immediately rejected upon submission > since the specified queue cannot serve the resource needs of the submitted > job. > > Command to run: > {code:java} > bin/yarn jar > "./share/hadoop/mapreduce/hadoop-mapreduce-examples-$MY_HADOOP_VERSION.jar" > pi -Dmapreduce.job.queuename=sample_queue 1 1000;{code} > fair-scheduler.xml queue config (excerpt): > > {code:java} > <queue name="sample_queue"> > <minResources>10000 mb,0vcores</minResources> > <maxResources>90000 mb,0vcores</maxResources> > <maxRunningApps>50</maxRunningApps> > <maxAMShare>-1.0f</maxAMShare> > <weight>2.0</weight> > <schedulingPolicy>fair</schedulingPolicy> > </queue> > {code} > Diagnostic message from the web UI: > {code:java} > Wed May 02 06:35:57 -0700 2018] Application is added to the scheduler and is > not yet activated. (Resource request: <memory:1536, vCores:1> exceeds current > queue or its parents maximum resource allowed).{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org