[ 
https://issues.apache.org/jira/browse/YARN-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497004#comment-16497004
 ] 

Wangda Tan commented on YARN-8349:
----------------------------------

Thanks [~billie.rinaldi], 

A couple of questions / comments. 

1) For the registry cleanup, I think it is safe to place under 
{{RMAppImpl.FinalTransition}} (instead of doing it in kill-transition only). We 
probably don't need to cleanup when user calls destroy service, etc. In my 
mind, cleanup registries it in destroy service is only useful when RM is down, 
which is a rare case to me, and all apps will go to final state.

2) If you agree with #1, the method name should be renamed to something like 
{{cleanUpAfterServiceFinished}}

3) Since now cleanUpRegistry will be called for every app no matter if it is a 
service or not. And this could be called when registry server is not enabled 
(is it possible?) In this case, we need to make sure that if registry server is 
not enabled, it won't cause RM slowdown or crash. Could you confirm this?

> Remove YARN registry entries when a service is killed by the RM
> ---------------------------------------------------------------
>
>                 Key: YARN-8349
>                 URL: https://issues.apache.org/jira/browse/YARN-8349
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn-native-services
>    Affects Versions: 3.2.0, 3.1.1
>            Reporter: Shane Kumpf
>            Assignee: Billie Rinaldi
>            Priority: Major
>         Attachments: YARN-8349.1.patch, YARN-8349.2.patch
>
>
> As the title states, when a service is killed by the RM (for exceeding its 
> lifetime for example), the YARN registry entries should be cleaned up.
> Without cleanup, DNS can contain multiple hostnames for a single IP address 
> in the case where IPs are reused. This impacts reverse lookups, which breaks 
> services, such as kerberos, that depend on those lookups.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to