[ https://issues.apache.org/jira/browse/YARN-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506566#comment-16506566 ]
Botong Huang commented on YARN-7953: ------------------------------------ Overall it looks good to me. Some minor things for v4 patch: In the pom file, include the actual json file, rather than * FederationGlobalView line 36, extra space before Cloneable. Similar at line 159 line 69, remove empty line line 80, extra space before catch (can you reformat the whole patch again? ) line 81, replace System.out with LOG.info line 160, super.clone() is redundant. FederationQueue line 47, this is a tree of queues rather than a single queue right? line 52-61, please add some comments explaining these fields line 588, Iterator<FederationQueue> iterator() TestFederationQueue line 62, replace all System.out with LOG.info line 72, remove variable tot not used > [GQ] Data structures for federation global queues calculations > -------------------------------------------------------------- > > Key: YARN-7953 > URL: https://issues.apache.org/jira/browse/YARN-7953 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Carlo Curino > Assignee: Abhishek Modi > Priority: Major > Attachments: YARN-7953-YARN-7402.v1.patch, > YARN-7953-YARN-7402.v2.patch, YARN-7953-YARN-7402.v3.patch, > YARN-7953-YARN-7402.v4.patch, YARN-7953.v1.patch > > > This Jira tracks data structures and helper classes used by the core > algorithms of YARN-7402 umbrella Jira (currently YARN-7403, and YARN-7834). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org