[ 
https://issues.apache.org/jira/browse/YARN-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510177#comment-16510177
 ] 

Eric Yang commented on YARN-8411:
---------------------------------

[~billie.rinaldi] Thank you for the patch, the approach looks good.  One minor 
nitpick:

{code}
              try {
                serviceClient.actionBuild(service);
              } catch (Exception e) {
                LOG.info("Got exception saving {}, will attempt to start " +
                    "service", service.getName());
              }
              ApplicationId applicationId = serviceClient
                  .actionStartAndGetId(service.getName());
               return applicationId;
{code}

The information logging looks like an error.  It will be more informative, to 
catch the already exist exception, and change the message to:

{code}
"Service {} already exist, will attempt to start service"
{code}

> Enable stopped system services to be started during RM start
> ------------------------------------------------------------
>
>                 Key: YARN-8411
>                 URL: https://issues.apache.org/jira/browse/YARN-8411
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>            Priority: Critical
>         Attachments: YARN-8411.01.patch
>
>
> With YARN-8048, the RM can launch system services using the YARN service 
> framework. If the service app is in a stopped state, user intervention is 
> required to delete the service so that the RM can launch it again when the RM 
> is restarted. It would be an improvement for the RM to be able to start a 
> stopped system service.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to