[ 
https://issues.apache.org/jira/browse/YARN-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523054#comment-16523054
 ] 

Miklos Szegedi commented on YARN-8461:
--------------------------------------

[~haibochen], thank you for the patch.
{code:java}
188     if (status.contains(CGroupsHandler.UNDER_OOM)) {
189     LOG.warn("Container " + containerId + " under OOM based on cgroups.");
190     return Optional.of(true);
191     }{code}
The else branch should return {{Optional.of(false);}}

> Support strict memory control on individual container with elastic control 
> memory mechanism
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-8461
>                 URL: https://issues.apache.org/jira/browse/YARN-8461
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 3.2.0
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>            Priority: Major
>         Attachments: YARN-8461.00.patch
>
>
> YARN-4599 adds elastic memory control that disables oom killer for the root 
> container cgroup. Hence, all containers have their oom killer disabled 
> because they inherit the setting from the root container cgroup. Hence, when 
> strict memory control on individual containers is also enabled, the container 
> will be frozen but not killed. We can let the container monitoring thread to 
> take care of the frozen containers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to