[
https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540965#comment-16540965
]
Vrushali C commented on YARN-8270:
----------------------------------
Hi [~haibochen]
Gentle ping for any further thoughts on Sushil's patch.
[~Sushil-K-S] I had a couple of things:
- I see Time.monotonicNow() in some places and System.nanoTime() in others. For
example, TimelineReaderWebServices has start time as one and endtime as other.
Not sure if that was intentional. Perhaps we can use only one in all places, I
think Time.monotonicNow may be better
- In TimelineCollectorWebService # putEntities, I believe we are looking to
measure the entire function call time? Or are we looking to measure just the
putEntitiesAsync call at line 177 at
https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/collector/TimelineCollectorWebService.java#L177
or the putEntities call at
https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/collector/TimelineCollectorWebService.java#L180
?
- Also, calculating the end time in getElapsedTimeMs may not be the accurate
measurement of elapsed time. The end time should be obtained in the finally
block and passed in as an argument to getElapsedTimeMs.
> Adding JMX Metrics for Timeline Collector and Reader
> ----------------------------------------------------
>
> Key: YARN-8270
> URL: https://issues.apache.org/jira/browse/YARN-8270
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: ATSv2, timelineserver
> Reporter: Sushil Ks
> Assignee: Sushil Ks
> Priority: Major
> Attachments: YARN-8270.001.patch
>
>
> This Jira is for emitting JMX Metrics for ATS v2 Timeline Collector and
> Timeline Reader, basically for Timeline Collector it tries to capture
> success, failure and latencies for *putEntities* and *putEntitiesAsync* from
> *TimelineCollectorWebService* and all the API's success, failure and
> latencies for fetching TimelineEntities from *TimelineReaderWebServices*.
> This would actually help in monitoring and measuring performance for ATSv2 at
> scale.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
