[ https://issues.apache.org/jira/browse/YARN-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545996#comment-16545996 ]
genericqa commented on YARN-8528: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} docker {color} | {color:red} 0m 8s{color} | {color:red} Docker failed to build yetus/hadoop:abb62dd. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | YARN-8528 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12931877/YARN-8528.001.patch | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/21269/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > ContainerAllocation.state should be private and unchangeable > ------------------------------------------------------------ > > Key: YARN-8528 > URL: https://issues.apache.org/jira/browse/YARN-8528 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler > Reporter: Xintong Song > Priority: Major > Attachments: YARN-8528.001.patch > > > ContainerAllocation.LOCALITY_SKIPPED is final static, and its .state should > always be AllocationState.LOCALITY_SKIPPED. However, this variable is public > and is accidentally changed to AllocationState.APP_SKIPPED in > RegularContainerAllocator under certain conditions. Once that happens, all > following LOCALITY_SKIPPED situations will be treated as APP_SKIPPED. > Similar risks exist for > ContainerAllocation.PRIORITY_SKIPPED/APP_SKIPPED/QUEUE_SKIPPED. > ContainerAllocation.state should be private and should not be changed. If > changes are needed, a new ContainerAllocation should be created. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org