[ https://issues.apache.org/jira/browse/YARN-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770575#comment-13770575 ]
Hadoop QA commented on YARN-1128: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12603779/yarn-1128-1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1955//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1955//console This message is automatically generated. > FifoPolicy.computeShares throws NPE on empty list of Schedulables > ----------------------------------------------------------------- > > Key: YARN-1128 > URL: https://issues.apache.org/jira/browse/YARN-1128 > Project: Hadoop YARN > Issue Type: Bug > Components: scheduler > Affects Versions: 2.1.0-beta > Reporter: Sandy Ryza > Assignee: Karthik Kambatla > Attachments: yarn-1128-1.patch > > > FifoPolicy gives all of a queue's share to the earliest-scheduled application. > {code} > Schedulable earliest = null; > for (Schedulable schedulable : schedulables) { > if (earliest == null || > schedulable.getStartTime() < earliest.getStartTime()) { > earliest = schedulable; > } > } > earliest.setFairShare(Resources.clone(totalResources)); > {code} > If the queue has no schedulables in it, earliest will be left null, leading > to an NPE on the last line. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira