[ https://issues.apache.org/jira/browse/YARN-7133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553197#comment-16553197 ]
Haibo Chen commented on YARN-7133: ---------------------------------- [~snemeth] I am not quite familiar with the reasons why putting lock() inside try-catch block is a bad idea. Do you mind sharing some insights in case folks like me are wondering? > Clean up lock-try order in fair scheduler > ----------------------------------------- > > Key: YARN-7133 > URL: https://issues.apache.org/jira/browse/YARN-7133 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler > Affects Versions: 3.0.0-alpha4 > Reporter: Daniel Templeton > Assignee: Szilard Nemeth > Priority: Major > Labels: newbie > Attachments: YARN-7133.001.patch > > > There are many places that follow the pattern:{code}try { > lock.lock(); > ... > } finally { > lock.unlock(); > }{code} > There are a couple of reasons that's a bad idea. The correct pattern > is:{code}lock.lock(); > try { > ... > } finally { > lock.unlock(); > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org