[ 
https://issues.apache.org/jira/browse/YARN-8509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554956#comment-16554956
 ] 

Zian Chen commented on YARN-8509:
---------------------------------

[~sunilg], I found something interesting while address the failed UT 
TestContainerAllocation#testPendingResourcesConsideringUserLimit, after we 
change the logic in patch 001, we actually allows pending resource to be simply 
reach whatever we made pending on the current app regardless of the max 
capacity hard limit. I didn't notice this before in my own UTs, my opinion for 
pending resource is it can go beyond user limit, but still cannot beyond maxCap 
- usedCap limit. What's your opinion?

> Fix UserLimit calculation for preemption to balance scenario after queue 
> satisfied  
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-8509
>                 URL: https://issues.apache.org/jira/browse/YARN-8509
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>            Reporter: Zian Chen
>            Assignee: Zian Chen
>            Priority: Major
>         Attachments: YARN-8509.001.patch
>
>
> In LeafQueue#getTotalPendingResourcesConsideringUserLimit, we calculate total 
> pending resource based on user-limit percent and user-limit factor which will 
> cap pending resource for each user to the minimum of user-limit pending and 
> actual pending. This will prevent queue from taking more pending resource to 
> achieve queue balance after all queue satisfied with its ideal allocation.
>  
> We need to change the logic to let queue pending can reach at most 
> (Queue_max_capacity - Queue_used_capacity).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to