[
https://issues.apache.org/jira/browse/YARN-8263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564136#comment-16564136
]
Jason Lowe commented on YARN-8263:
----------------------------------
Thanks for the patch!
Patch looks good, but I think there's even more we can cleanup here which can
be done in a separate JIRA if desired.
DockerCommand#preparePrivilegedOperation has a conf argument for the sole
purpose of constructing the DockerClient which is no longer necessary as part
of this patch. Even if it eventually needs one, it is available in the
NMContext parameter. That now unused conf argument should be removed.
Transitively there are callers of preparePrivilegedOperation that are
forwarding conf arguments that would no longer be needed, etc.
> DockerClient still touches hadoop.tmp.dir
> -----------------------------------------
>
> Key: YARN-8263
> URL: https://issues.apache.org/jira/browse/YARN-8263
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.1.1
> Reporter: Jason Lowe
> Assignee: Craig Condit
> Priority: Minor
> Labels: Docker
> Attachments: YARN-8263.001.patch
>
>
> The DockerClient constructor fails if hadoop.tmp.dir is not set and proceeds
> to create a directory there. After YARN-8064 there's no longer a need to
> touch the temporary directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
