[
https://issues.apache.org/jira/browse/YARN-8287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568185#comment-16568185
]
Shane Kumpf commented on YARN-8287:
-----------------------------------
Thanks for the patch, [~ccondit-target]! Overall this looks good. A couple of
items I wanted to bring up after additional review.
1) Let's remove the following, since it refers to the Phase 1 Jira.
{code:java}
Docker support in the LCE is still evolving. To track progress, follow
YARN-3611, the umbrella JIRA for Docker support improvements. {code}
2) A point of confusion we see is that the example image doesn't exist. We
could change images/hadoop-docker:latest to apache/hadoop-runner:trunk, which
does exist. We'd need to do a quick sanity test to see if the image works with
YARN. Maybe best for a follow on JIRA given the testing involved.
3) With the changes to allow disabling the YARN launch script in favor of
running whatever is specified in the image, I think the following needs to be
remove/updated. There is already a section called Docker Container ENTRYPOINT
support. I think we can clean this up a bit make it easier to understand this
feature. Given the need to explain YARN's existing launching logic, this also
may be best for a follow on ticket as it will require some testing to fully
describe the feature.
{code:java}
If a Docker image has a command set, the behavior will depend on whether the
YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE is set to true. If so, the
command will be overridden when LCE launches the image with YARN's container
launch script.
If a Docker image has an entry point set, the entry point will be honored, but
the default command may be overridden, as just mentioned above. Unless the
entry point is something similar to sh -c or
YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE is set to true, the net
result will likely be undesirable. Because the YARN container launch script is
required to correctly launch the YARN task, use of entry points is discouraged.
{code}
I think if we address #1 as part of this patch and open follow on JIRAs for the
other two, this is ready to go.
> Update documentation and yarn-default related to the Docker runtime
> -------------------------------------------------------------------
>
> Key: YARN-8287
> URL: https://issues.apache.org/jira/browse/YARN-8287
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Shane Kumpf
> Assignee: Craig Condit
> Priority: Minor
> Labels: Docker
> Attachments: YARN-8287.001.patch
>
>
> There are a few typos and omissions in the documentation and yarn-default wrt
> running Docker containers on YARN. Below is what I noticed, but a more
> thorough review is still needed:
> * docker.allowed.volume-drivers is not documented
> * None of the GPU or FPGA related items are in the Docker docs.
> * "To run without any capabilites," - typo in yarn-default.xml
> * remove <!--Docker configuration--> from yarn-default.xml
> * yarn.nodemanager.runtime.linux.docker.delayed-removal.allowed missing from
> docs
> * yarn.nodemanager.runtime.linux.docker.stop.grace-period missing from docs
> * The user remapping features are missing from the docs, we should
> explicitly call this out.
> * The privileged container section could use a bit of rework to outline the
> risks of the feature.
> * Is it time to remove the security warnings? The community has made many
> improvements since that warning was added.
> * "path within the contatiner" typo
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
