[ https://issues.apache.org/jira/browse/YARN-8590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569376#comment-16569376 ]
Miklos Szegedi commented on YARN-8590: -------------------------------------- Thank you for the patch [~haibochen]. {code:java} 941 container.setExecutionType(ExecutionType.GUARANTEED);{code} This code will execute, even if the token update failed. I think this function should be atomic and keep the execution type, if the token generation fails. > Fair scheduler promotion does not update container execution type and token > --------------------------------------------------------------------------- > > Key: YARN-8590 > URL: https://issues.apache.org/jira/browse/YARN-8590 > Project: Hadoop YARN > Issue Type: Sub-task > Components: fairscheduler > Affects Versions: YARN-1011 > Reporter: Haibo Chen > Assignee: Haibo Chen > Priority: Major > Attachments: YARN-8590-YARN-1011.00.patch, > YARN-8590-YARN-1011.01.patch > > > Fair Scheduler promotion of opportunistic containers does not update > container execution type and token. This leads to incorrect resource > accounting when the promoted containers are released. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org