[ https://issues.apache.org/jira/browse/YARN-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575312#comment-16575312 ]
Szilard Nemeth commented on YARN-4946: -------------------------------------- Hi [~rkanter]! Thanks for your comments. 1. Fixed 2. Good point, somehow my IDE generates xxTest class names by default. 3. Removed reflection logic 4. Good point, removed those unnecessary log aggregation related testcases. Exactly, the logic is the same and it was mainly a readability improvement so I created a follow-up jira: YARN-8644 6. Fixed > RM should not consider an application as COMPLETED when log aggregation is > not in a terminal state > -------------------------------------------------------------------------------------------------- > > Key: YARN-4946 > URL: https://issues.apache.org/jira/browse/YARN-4946 > Project: Hadoop YARN > Issue Type: Improvement > Components: log-aggregation > Affects Versions: 2.8.0 > Reporter: Robert Kanter > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-4946.001.patch, YARN-4946.002.patch, > YARN-4946.003.patch, YARN-4946.004.patch > > > MAPREDUCE-6415 added a tool that combines the aggregated log files for each > Yarn App into a HAR file. When run, it seeds the list by looking at the > aggregated logs directory, and then filters out ineligible apps. One of the > criteria involves checking with the RM that an Application's log aggregation > status is not still running and has not failed. When the RM "forgets" about > an older completed Application (e.g. RM failover, enough time has passed, > etc), the tool won't find the Application in the RM and will just assume that > its log aggregation succeeded, even if it actually failed or is still running. > We can solve this problem by doing the following: > The RM should not consider an app to be fully completed (and thus removed > from its history) until the aggregation status has reached a terminal state > (e.g. SUCCEEDED, FAILED, TIME_OUT). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org