[
https://issues.apache.org/jira/browse/YARN-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775823#comment-13775823
]
Hadoop QA commented on YARN-1228:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12604697/YARN-1228.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1985//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1985//console
This message is automatically generated.
> Clean up Fair Scheduler configuration loading
> ---------------------------------------------
>
> Key: YARN-1228
> URL: https://issues.apache.org/jira/browse/YARN-1228
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Affects Versions: 2.1.1-beta
> Reporter: Sandy Ryza
> Assignee: Sandy Ryza
> Attachments: YARN-1228.patch
>
>
> Currently the Fair Scheduler is configured in two ways
> * An allocations file that has a different format than the standard Hadoop
> configuration file, which makes it easier to specify hierarchical objects
> like queues and their properties.
> * With properties like yarn.scheduler.fair.max.assign that are specified in
> the standard Hadoop configuration format.
> The standard and default way of configuring it is to use fair-scheduler.xml
> as the allocations file and to put the yarn.scheduler properties in
> yarn-site.xml.
> It is also possible to specify a different file as the allocations file, and
> to place the yarn.scheduler properties in fair-scheduler.xml, which will be
> interpreted as in the standard Hadoop configuration format. This flexibility
> is both confusing and unnecessary.
> Additionally, the allocation file is loaded as fair-scheduler.xml from the
> classpath if it is not specified, but is loaded as a File if it is. This
> causes two problems
> 1. We see different behavior when not setting the
> yarn.scheduler.fair.allocation.file, and setting it to fair-scheduler.xml,
> which is its default.
> 2. Classloaders may choose to cache resources, which can break the reload
> logic when yarn.scheduler.fair.allocation.file is not specified.
> We should never allow the yarn.scheduler properties to go into
> fair-scheduler.xml. And we should always load the allocations file as a
> file, not as a resource on the classpath. To preserve existing behavior and
> allow loading files from the classpath, we can look for files on the
> classpath, but strip of their scheme and interpret them as Files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
