[
https://issues.apache.org/jira/browse/YARN-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583079#comment-16583079
]
Jason Lowe commented on YARN-8640:
----------------------------------
Bummer, the 2.8 docker build appears to be busted. In the meantime I took a
look at the 2.8 patch and had one concern. It looks like we are now leaving
write_exit_code_file_as_nm as root instead of as the yarn user which was done
previously. It would be safer to leave as the yarn user as was done originally.
bq. Let me know if I should remove the test-container-executor.c change from
the patch.
It's a small change and fixes the unit test, so I'm OK with that staying in the
2.7 version.
> Restore previous state in container-executor after failure
> ----------------------------------------------------------
>
> Key: YARN-8640
> URL: https://issues.apache.org/jira/browse/YARN-8640
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Jim Brennan
> Assignee: Jim Brennan
> Priority: Major
> Fix For: 2.10.0, 3.2.0, 2.9.2, 3.0.4, 3.1.2
>
> Attachments: YARN-8640-branch-2.7.001.patch,
> YARN-8640-branch-2.8.001.patch, YARN-8640.001.patch
>
>
> The container-executor function {{write_exit_code_file_as_nm}} had a number
> of failure conditions where it just returns -1 without restoring previous
> state.
> This is not a problem in any of the places where it is currently called, but
> it could be a problem if future code changes call it before code that depends
> on the previous state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
