[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588996#comment-16588996
]
Weiwei Yang commented on YARN-7863:
-----------------------------------
Hi [~sunilg]
Thanks for the updates. I think v8 patch has addressed most of my concerns. Two
comments:
PlacementConstraintsUtil.java
canSatisfyNodeConstraintExpresssion: looks like the logic only supports
affinity to node-attributes, does it support anti-affinity? e.g
{{targetNotIn(NODE, nodeAttribute("java", "1.8"))}}, can container with such PC
be allocated to nodes where {{java != 1.8}}? If it is not straightforward to
support this with {{targetIn}} and {{targetNotIn}}, I think we can add a API
something like {{targetNodeAttribute(Operator.EQ, "java", "1.8")}} ? For this
version, we can claim only to support {{EQ}} and {{NE}}. What do you think?
TestPlacementConstraints.java
line 72 and 85: why it is still {{nodeAttribute("java", "java=1.8")}}? The
value should be "1.8" alone right?
Thanks
> Modify placement constraints to support node attributes
> -------------------------------------------------------
>
> Key: YARN-7863
> URL: https://issues.apache.org/jira/browse/YARN-7863
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil Govindan
> Assignee: Sunil Govindan
> Priority: Major
> Attachments: YARN-7863-YARN-3409.002.patch,
> YARN-7863-YARN-3409.003.patch, YARN-7863-YARN-3409.004.patch,
> YARN-7863-YARN-3409.005.patch, YARN-7863-YARN-3409.006.patch,
> YARN-7863-YARN-3409.007.patch, YARN-7863-YARN-3409.008.patch,
> YARN-7863.v0.patch
>
>
> This Jira will track to *Modify existing placement constraints to support
> node attributes.*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
